Unverified Commit 222a87f6 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

spi: cadence-quadspi: Assume device could match via platform



Driver has only of_device_id table, however it also has MODULE_ALIAS()
for platform name, thus assume there is a configuration where this can
be loaded outside of OF system.  In such case of_device_get_match_data()
will return NULL, which is already checked in one place of probe()
function but not in the other, leading to Smatch warning:

  drivers/spi/spi-cadence-quadspi.c:1942 cqspi_probe() error: we previously assumed 'ddata' could be null (see line 1885)

Driver should be consistent, so assume device can be matched via
platform bus and of_device_get_match_data() can indeed return NULL.
This is also possible with malformed DTS on OF-platform: no unit address
and device node name matching driver name.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20250501-n-smatch-fixes-v2-3-d2ad9c1f2e67@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f4ea37a4
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1949,7 +1949,7 @@ static int cqspi_probe(struct platform_device *pdev)

	host->num_chipselect = cqspi->num_chipselect;

	if (ddata->quirks & CQSPI_SUPPORT_DEVICE_RESET)
	if (ddata && (ddata->quirks & CQSPI_SUPPORT_DEVICE_RESET))
		cqspi_device_reset(cqspi);

	if (cqspi->use_direct_mode) {