Commit 2240a50e authored by Zenghui Yu's avatar Zenghui Yu Committed by Oliver Upton
Browse files

KVM: arm64: vgic-debug: Don't put unmarked LPIs 



If there were LPIs being mapped behind our back (i.e., between .start() and
.stop()), we would put them at iter_unmark_lpis() without checking if they
were actually *marked*, which is obviously not good.

Switch to use the xa_for_each_marked() iterator to fix it.

Cc: stable@vger.kernel.org
Fixes: 85d3ccc8 ("KVM: arm64: vgic-debug: Use an xarray mark for debug iterator")
Signed-off-by: default avatarZenghui Yu <yuzenghui@huawei.com>
Reviewed-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20240817101541.1664-1-yuzenghui@huawei.com


Signed-off-by: default avatarOliver Upton <oliver.upton@linux.dev>
parent 9eb18136

arch/arm64/kvm/vgic/vgic-debug.c

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ static void iter_unmark_lpis(struct kvm *kvm) 
	struct vgic_irq *irq;

	unsigned long intid;



	xa_for_each(&dist->lpi_xa, intid, irq) {

	xa_for_each_marked(&dist->lpi_xa, intid, irq, LPI_XA_MARK_DEBUG_ITER) {

		xa_clear_mark(&dist->lpi_xa, intid, LPI_XA_MARK_DEBUG_ITER);

		vgic_put_irq(kvm, irq);

	}