Commit 225d09d6 authored by Thomas Richter's avatar Thomas Richter Committed by Heiko Carstens
Browse files

s390/pai: fix attr_event_free upper limit for pai device drivers 



When the device drivers are initialized, a sysfs directory
is created. This contains many attributes which are allocated with
kzalloc(). Should it fail, the memory for the attributes already
created is freed in attr_event_free(). Its second parameter is number
of attribute elements to delete. This parameter is off by one.
When i. e. the 10th attribute fails to get created, attributes
numbered 0 to 9 should be deleted. Currently only attributes
numbered 0 to 8 are deleted.

Fixes: 39d62336 ("s390/pai: add support for cryptography counters")
Reported-by: default avatarSumanth Korikkar <sumanthk@linux.ibm.com>
Signed-off-by: default avatarThomas Richter <tmricht@linux.ibm.com>
Acked-by: default avatarSumanth Korikkar <sumanthk@linux.ibm.com>
Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
parent e98eda92

arch/s390/kernel/perf_pai_crypto.c

+1 −1
Original line number Diff line number Diff line
@@ -721,7 +721,7 @@ static int __init attr_event_init(void) 
	for (i = 0; i < ARRAY_SIZE(paicrypt_ctrnames); i++) {

		ret = attr_event_init_one(attrs, i);

		if (ret) {

			attr_event_free(attrs, i - 1);

			attr_event_free(attrs, i);

			return ret;

		}

	}

arch/s390/kernel/perf_pai_ext.c

+1 −1
Original line number Diff line number Diff line
@@ -611,7 +611,7 @@ static int __init attr_event_init(void) 
	for (i = 0; i < ARRAY_SIZE(paiext_ctrnames); i++) {

		ret = attr_event_init_one(attrs, i);

		if (ret) {

			attr_event_free(attrs, i - 1);

			attr_event_free(attrs, i);

			return ret;

		}

	}