Commit 226a0baf authored Feb 03, 2025 by Abel Vesa Committed by Dmitry Baryshkov Feb 25, 2025

drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode



LTTPRs operating modes are defined by the DisplayPort standard and the
generic framework now provides a helper to switch between them, which
is handling the explicit disabling of non-transparent mode and its
disable->enable sequence mentioned in the DP Standard v2.0 section
3.6.6.1.

So use the new drm generic helper instead as it makes the code a bit
cleaner.

Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Danilo Krummrich <dakr@kernel.org> # via IRC
Link: https://patchwork.freedesktop.org/patch/msgid/20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-2-c865d0e56d6e@linaro.org


Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

parent 5e771547

drivers/gpu/drm/nouveau/nouveau_dp.c

+2 −15

Original line number	Diff line number	Diff line
		@@ -79,22 +79,9 @@ nouveau_dp_probe_dpcd(struct nouveau_connector *nv_connector,
		!drm_dp_read_lttpr_common_caps(aux, dpcd, outp->dp.lttpr.caps)) {
		int nr = drm_dp_lttpr_count(outp->dp.lttpr.caps);

		if (nr) {
		drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE,
		DP_PHY_REPEATER_MODE_TRANSPARENT);

		if (nr > 0) {
		ret = drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE,
		DP_PHY_REPEATER_MODE_NON_TRANSPARENT);
		if (ret != 1) {
		drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE,
		DP_PHY_REPEATER_MODE_TRANSPARENT);
		} else {
		if (!drm_dp_lttpr_init(aux, nr))
		outp->dp.lttpr.nr = nr;
		}
		}
		}
		}

		ret = drm_dp_read_dpcd_caps(aux, dpcd);
		if (ret < 0)