Commit 2295657a authored by Willy Huang's avatar Willy Huang Committed by Jiri Kosina
Browse files

HID: nintendo: Reduce JC_SUBCMD_RATE_MAX_ATTEMPTS 



The JC_SUBCMD_RATE_MAX_ATTEMPTS constant is currently set to 500.
In a worst-case scenario where all attempts consistently fail, this could
cause the loop to block for up to 60000 ms (500 * 60ms * 2, including the
additional retry after a timeout).

This change lowers the maximum potential blocking time to 3000 ms
(25 * 60ms * 2), improving system responsiveness and efficiency.

Signed-off-by: default avatarWilly Huang <willyhuang@google.com>
Reviewed-by: default avatarDaniel J. Ogorchock <djogorchock@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 2953fb65

drivers/hid/hid-nintendo.c

+1 −1
Original line number Diff line number Diff line
@@ -819,7 +819,7 @@ static void joycon_wait_for_input_report(struct joycon_ctlr *ctlr) 
#define JC_INPUT_REPORT_MAX_DELTA	17

#define JC_SUBCMD_TX_OFFSET_MS		4

#define JC_SUBCMD_VALID_DELTA_REQ	3

#define JC_SUBCMD_RATE_MAX_ATTEMPTS	500

#define JC_SUBCMD_RATE_MAX_ATTEMPTS	25

#define JC_SUBCMD_RATE_LIMITER_USB_MS	20

#define JC_SUBCMD_RATE_LIMITER_BT_MS	60

#define JC_SUBCMD_RATE_LIMITER_MS(ctlr)	((ctlr)->hdev->bus == BUS_USB ? JC_SUBCMD_RATE_LIMITER_USB_MS : JC_SUBCMD_RATE_LIMITER_BT_MS)