Commit 229bedbf authored by Aleksandr Mishin's avatar Aleksandr Mishin Committed by Jakub Kicinski
Browse files

net/mlx5: Fix tainted pointer delete is case of flow rules creation fail 



In case of flow rule creation fail in mlx5_lag_create_port_sel_table(),
instead of previously created rules, the tainted pointer is deleted
deveral times.
Fix this bug by using correct flow rules pointers.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 352899f3 ("net/mlx5: Lag, use buckets in hash mode")
Signed-off-by: default avatarAleksandr Mishin <amishin@t-argos.ru>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://lore.kernel.org/r/20240604100552.25201-1-amishin@t-argos.ru


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f8f0de9d

drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c

+6 −2
Original line number Diff line number Diff line
@@ -88,9 +88,13 @@ static int mlx5_lag_create_port_sel_table(struct mlx5_lag *ldev, 
								      &dest, 1);

			if (IS_ERR(lag_definer->rules[idx])) {

				err = PTR_ERR(lag_definer->rules[idx]);

				while (i--)

					while (j--)

				do {

					while (j--) {

						idx = i * ldev->buckets + j;

						mlx5_del_flow_rules(lag_definer->rules[idx]);

					}

					j = ldev->buckets;

				} while (i--);

				goto destroy_fg;

			}

		}