Unverified Commit 22a03ca7 authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

ASoC: codecs: wcd937x: fix OF node leaks on probe failure 



The component match entry release function will drop the references
taken while looking up the soundwire OF nodes when the platform device
is unbound.

Drop the additional references taken to avoid leaking them on probe
failure (e.g. probe deferral) and on driver unbind.

Fixes: 9be3ec19 ("ASoC: codecs: wcd937x: add wcd937x codec driver")
Cc: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Cc: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20251201093419.24474-2-johan@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c5fae31f

sound/soc/codecs/wcd937x.c

+2 −2
Original line number Diff line number Diff line
@@ -2841,7 +2841,7 @@ static int wcd937x_add_slave_components(struct wcd937x_priv *wcd937x, 
		dev_err(dev, "Couldn't parse phandle to qcom,rx-device!\n");

		return -ENODEV;

	}

	of_node_get(wcd937x->rxnode);



	component_match_add_release(dev, matchptr, component_release_of,

				    component_compare_of, wcd937x->rxnode);
@@ -2850,7 +2850,7 @@ static int wcd937x_add_slave_components(struct wcd937x_priv *wcd937x, 
		dev_err(dev, "Couldn't parse phandle to qcom,tx-device\n");

			return -ENODEV;

	}

	of_node_get(wcd937x->txnode);



	component_match_add_release(dev, matchptr, component_release_of,

				    component_compare_of, wcd937x->txnode);