Commit 22fb2eda authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Bjorn Helgaas
Browse files

PCI: Converge return paths in __assign_resources_sorted() 

All return paths want to free head list in __assign_resources_sorted(), so
add a label and use goto.

Link: https://lore.kernel.org/r/20241216175632.4175-13-ilpo.jarvinen@linux.intel.com


Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Tested-by: default avatarXiaochun Lee <lixc17@lenovo.com>
parent 9b54578b

drivers/pci/setup-bus.c

+3 −2
Original line number Diff line number Diff line
@@ -444,8 +444,7 @@ static void __assign_resources_sorted(struct list_head *head, 
		list_for_each_entry(dev_res, head, list)

			remove_from_list(realloc_head, dev_res->res);

		free_list(&save_head);

		free_list(head);

		return;

		goto out;

	}



	/* Check failed type */
@@ -488,6 +487,8 @@ static void __assign_resources_sorted(struct list_head *head, 
	/* Try to satisfy any additional optional resource requests */

	if (realloc_head)

		reassign_resources_sorted(realloc_head, head);



out:

	free_list(head);

}