Commit 22fdd8ba authored by Nina Schoetterl-Glausch's avatar Nina Schoetterl-Glausch Committed by Alexander Gordeev
Browse files

KVM: s390: vsie: Use virt_to_phys for facility control block 



In order for SIE to interpretively execute STFLE, it requires the real
or absolute address of a facility-list control block.
Before writing the location into the shadow SIE control block, convert
it from a virtual address.
We currently do not run into this bug because the lower 31 bits are the
same for virtual and physical addresses.

Signed-off-by: default avatarNina Schoetterl-Glausch <nsg@linux.ibm.com>
Link: https://lore.kernel.org/r/20240319164420.4053380-3-nsg@linux.ibm.com


Signed-off-by: default avatarJanosch Frank <frankja@linux.ibm.com>
Message-Id: <20240319164420.4053380-3-nsg@linux.ibm.com>
Signed-off-by: default avatarAlexander Gordeev <agordeev@linux.ibm.com>
parent 8692a24d

arch/s390/kvm/vsie.c

+2 −1
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 
#include <linux/list.h>

#include <linux/bitmap.h>

#include <linux/sched/signal.h>

#include <linux/io.h>



#include <asm/gmap.h>

#include <asm/mmu_context.h>
@@ -1005,7 +1006,7 @@ static int handle_stfle(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) 
		if (read_guest_real(vcpu, fac, &vsie_page->fac,

				    stfle_size() * sizeof(u64)))

			return set_validity_icpt(scb_s, 0x1090U);

		scb_s->fac = (__u32)(__u64) &vsie_page->fac;

		scb_s->fac = (u32)virt_to_phys(&vsie_page->fac);

	}

	return 0;

}