Commit 231e3410 authored by Qiuxu Zhuo's avatar Qiuxu Zhuo Committed by Tony Luck
Browse files

EDAC/ie31200: Fix the error path order of ie31200_init() 



The error path order of ie31200_init() is incorrect, fix it.

Fixes: 709ed1bc ("EDAC/ie31200: Fallback if host bridge device is already initialized")
Signed-off-by: default avatarQiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
Tested-by: default avatarGary Wang <gary.c.wang@intel.com>
Link: https://lore.kernel.org/r/20250310011411.31685-4-qiuxu.zhuo@intel.com
parent 3427befb

drivers/edac/ie31200_edac.c

+7 −5
Original line number Diff line number Diff line
@@ -619,7 +619,7 @@ static int __init ie31200_init(void) 


	pci_rc = pci_register_driver(&ie31200_driver);

	if (pci_rc < 0)

		goto fail0;

		return pci_rc;



	if (!mci_pdev) {

		ie31200_registered = 0;
@@ -630,11 +630,13 @@ static int __init ie31200_init(void) 
			if (mci_pdev)

				break;

		}



		if (!mci_pdev) {

			edac_dbg(0, "ie31200 pci_get_device fail\n");

			pci_rc = -ENODEV;

			goto fail1;

			goto fail0;

		}



		pci_rc = ie31200_init_one(mci_pdev, &ie31200_pci_tbl[i]);

		if (pci_rc < 0) {

			edac_dbg(0, "ie31200 init fail\n");
@@ -642,12 +644,12 @@ static int __init ie31200_init(void) 
			goto fail1;

		}

	}

	return 0;



	return 0;

fail1:

	pci_unregister_driver(&ie31200_driver);

fail0:

	pci_dev_put(mci_pdev);

fail0:

	pci_unregister_driver(&ie31200_driver);



	return pci_rc;

}