Commit 23413fe1 authored by Cristian Del Gobbo's avatar Cristian Del Gobbo Committed by Greg Kroah-Hartman
Browse files

staging: sm750fb: avoid chained assignment in setcolreg() 



Replace the chained assignment of red/green/blue with a temporary
variable and braces. This keeps behavior identical while improving
readability and satisfying checkpatch.

No functional change intended.

Signed-off-by: default avatarCristian Del Gobbo <cristiandelgobbo87@gmail.com>
Link: https://patch.msgid.link/20251102230139.1720-2-cristiandelgobbo87@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3a3fd27e

drivers/staging/sm750fb/sm750.c

+7 −2
Original line number Diff line number Diff line
@@ -537,8 +537,13 @@ static int lynxfb_ops_setcolreg(unsigned int regno, 
		return -EINVAL;

	}



	if (info->var.grayscale)

		red = green = blue = (red * 77 + green * 151 + blue * 28) >> 8;

	if (info->var.grayscale) {

		int lum = (red * 77 + green * 151 + blue * 28) >> 8;



		red = lum;

		green = lum;

		blue = lum;

	}



	if (var->bits_per_pixel == 8 &&

	    info->fix.visual == FB_VISUAL_PSEUDOCOLOR) {