Commit 23749cf3 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

backlight: gpio: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240305-backlight-probe-v2-1-609b0cf24bde@linaro.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 39234682

drivers/video/backlight/gpio_backlight.c

+3 −7
Original line number Diff line number Diff line
@@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev) 
	def_value = device_property_read_bool(dev, "default-on");



	gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);

	if (IS_ERR(gbl->gpiod)) {

		ret = PTR_ERR(gbl->gpiod);

		if (ret != -EPROBE_DEFER)

			dev_err(dev,

				"Error: The gpios parameter is missing or invalid.\n");

		return ret;

	}

	if (IS_ERR(gbl->gpiod))

		return dev_err_probe(dev, PTR_ERR(gbl->gpiod),

				     "The gpios parameter is missing or invalid\n");



	memset(&props, 0, sizeof(props));

	props.type = BACKLIGHT_RAW;