Commit 2376586f authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

ethtool: eeprom: add missing ethnl_ops_begin() / _complete() during fallback 



All ethtool driver op calls should be sandwiched between
ethnl_ops_begin() / ethnl_ops_complete(). In Netlink eeprom code,
if the paged access failed we fall back to old API, but we
first call _complete() and the fallback never does its own
ethnl_ops_begin(). Move the fallback into the _begin() / _complete()
section.

Fixes: 96d971e3 ("ethtool: Add fallback to get_module_eeprom from netlink command")
Reviewed-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20260526153533.2779187-10-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a8d8bef6

net/ethtool/eeprom.c

+2 −3
Original line number Diff line number Diff line
@@ -141,12 +141,11 @@ static int eeprom_prepare_data(const struct ethnl_req_info *req_base, 
	return 0;



err_ops:

	if (ret == -EOPNOTSUPP)

		ret = eeprom_fallback(request, reply);

	ethnl_ops_complete(dev);

err_free:

	kfree(page_data.data);



	if (ret == -EOPNOTSUPP)

		return eeprom_fallback(request, reply);

	return ret;

}