Commit 23773bd8 authored Jun 15, 2025 by Tamir Duberstein Committed by Miguel Ojeda Jun 22, 2025

rust: enable `clippy::as_ptr_cast_mut` lint

In Rust 1.66.0, Clippy introduced the `as_ptr_cast_mut` lint [1]:

> Since `as_ptr` takes a `&self`, the pointer won’t have write
> permissions unless interior mutability is used, making it unlikely
> that having it as a mutable pointer is correct.

There is only one affected callsite, and the change amounts to replacing
`as _` with `.cast_mut().cast()`. This doesn't change the semantics, but
is more descriptive of what's going on.

Apply this change and enable the lint -- no functional change intended.

Link: https://rust-lang.github.io/rust-clippy/master/index.html#as_ptr_cast_mut

 [1]
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Danilo Krummrich <dakr@kernel.org>
Link: https://lore.kernel.org/r/20250615-ptr-as-ptr-v12-3-f43b024581e8@gmail.com


Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

parent d8c9e735

Makefile

+1 −0

Original line number	Diff line number	Diff line
		@@ -479,6 +479,7 @@ export rust_common_flags := --edition=2021 \
		-Wrust_2018_idioms \
		-Wunreachable_pub \
		-Wclippy::all \
		-Wclippy::as_ptr_cast_mut \
		-Wclippy::ignored_unit_patterns \
		-Wclippy::mut_mut \
		-Wclippy::needless_bitwise_bool \

rust/kernel/devres.rs

+1 −1

Original line number	Diff line number	Diff line
		@@ -143,7 +143,7 @@ fn remove_action(this: &Arc<Self>) -> bool {
		bindings::devm_remove_action_nowarn(
		this.dev.as_raw(),
		Some(this.callback),
		this.as_ptr() as _,
		this.as_ptr().cast_mut().cast(),
		)
		} == 0;