Commit 2399401f authored by Zheng Yongjun's avatar Zheng Yongjun Committed by Miquel Raynal
Browse files

mtd: maps: pxa2xx-flash: fix memory leak in probe 



Free 'info' upon remapping error to avoid a memory leak.

Fixes: e644f7d6 ("[MTD] MAPS: Merge Lubbock and Mainstone drivers into common PXA2xx driver")
Signed-off-by: default avatarZheng Yongjun <zhengyongjun3@huawei.com>
[<miquel.raynal@bootlin.com>: Reword the commit log]
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20221119073307.22929-1-zhengyongjun3@huawei.com
parent 56570bda

drivers/mtd/maps/pxa2xx-flash.c

+2 −0
Original line number Diff line number Diff line
@@ -64,6 +64,7 @@ static int pxa2xx_flash_probe(struct platform_device *pdev) 
	if (!info->map.virt) {

		printk(KERN_WARNING "Failed to ioremap %s\n",

		       info->map.name);

		kfree(info);

		return -ENOMEM;

	}

	info->map.cached = ioremap_cache(info->map.phys, info->map.size);
@@ -85,6 +86,7 @@ static int pxa2xx_flash_probe(struct platform_device *pdev) 
		iounmap((void *)info->map.virt);

		if (info->map.cached)

			iounmap(info->map.cached);

		kfree(info);

		return -EIO;

	}

	info->mtd->dev.parent = &pdev->dev;