Commit 23b128bb authored by Lyude Paul's avatar Lyude Paul Committed by Miguel Ojeda
Browse files

rust: time: Pass correct timer mode ID to hrtimer_start_range_ns 



While rebasing rvkms I noticed that timers I was setting seemed to have
pretty random timer values that amounted slightly over 2x the time value I
set each time. After a lot of debugging, I finally managed to figure out
why: it seems that since we moved to Instant and Delta, we mistakenly
began passing the clocksource ID to hrtimer_start_range_ns, when we should
be passing the timer mode instead. Presumably, this works fine for simple
relative timers - but immediately breaks on other types of timers.

So, fix this by passing the ID for the timer mode instead.

Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Acked-by: default avatarAndreas Hindborg <a.hindborg@kernel.org>
Reviewed-by: default avatarFUJITA Tomonori <fujita.tomonori@gmail.com>
Fixes: e0c0ab04 ("rust: time: Make HasHrTimer generic over HrTimerMode")
Link: https://lore.kernel.org/r/20250710225129.670051-1-lyude@redhat.com


[ Removed cast, applied `rustfmt`, fixed `Fixes:` tag. - Miguel ]
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 77580e80

rust/kernel/time/hrtimer.rs

+1 −1
Original line number Diff line number Diff line
@@ -398,7 +398,7 @@ unsafe fn start(this: *const Self, expires: <Self::TimerMode as HrTimerMode>::Ex 
                Self::c_timer_ptr(this).cast_mut(),

                expires.as_nanos(),

                0,

                <Self::TimerMode as HrTimerMode>::Clock::ID as u32,

                <Self::TimerMode as HrTimerMode>::C_MODE,

            );

        }

    }