Commit 23cef42d authored by Zhongqiu Han's avatar Zhongqiu Han Committed by Martin K. Petersen
Browse files

scsi: aha152x: Use DECLARE_COMPLETION_ONSTACK for non-constant completion 



The _ONSTACK variant should be used for on-stack completion, otherwise it
will break lockdep. See also commit 6e9a4738 ("[PATCH] completions:
lockdep annotate on stack completions").

Signed-off-by: default avatarZhongqiu Han <quic_zhonhan@quicinc.com>
Link: https://lore.kernel.org/r/20240705103614.3650637-1-quic_zhonhan@quicinc.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 6ca9fede

drivers/scsi/aha152x.c

+1 −1
Original line number Diff line number Diff line
@@ -1072,7 +1072,7 @@ static int aha152x_abort(struct scsi_cmnd *SCpnt) 
static int aha152x_device_reset(struct scsi_cmnd * SCpnt)

{

	struct Scsi_Host *shpnt = SCpnt->device->host;

	DECLARE_COMPLETION(done);

	DECLARE_COMPLETION_ONSTACK(done);

	int ret, issued, disconnected;

	unsigned char old_cmd_len = SCpnt->cmd_len;

	unsigned long flags;