Commit 23db1577 authored by Jani Nikula's avatar Jani Nikula
Browse files

drm/i915/dsi: log send packet sequence errors 



We might be getting send packet sequence errors and never know. Log them
as errors. Also upgrade the not supported read commands to errors.

v2: Also error log -EOPNOTSUPP (Ville)

Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20251029084603.2254982-1-jani.nikula@intel.com


Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 7460b69f

drivers/gpu/drm/i915/display/intel_dsi_vbt.c

+13 −9
Original line number Diff line number Diff line
@@ -106,6 +106,7 @@ static const u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi, 
	u8 type, flags, seq_port;

	u16 len;

	enum port port;

	ssize_t ret;



	drm_dbg_kms(display->drm, "\n");
@@ -138,36 +139,39 @@ static const u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi, 


	switch (type) {

	case MIPI_DSI_GENERIC_SHORT_WRITE_0_PARAM:

		mipi_dsi_generic_write(dsi_device, NULL, 0);

		ret = mipi_dsi_generic_write(dsi_device, NULL, 0);

		break;

	case MIPI_DSI_GENERIC_SHORT_WRITE_1_PARAM:

		mipi_dsi_generic_write(dsi_device, data, 1);

		ret = mipi_dsi_generic_write(dsi_device, data, 1);

		break;

	case MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM:

		mipi_dsi_generic_write(dsi_device, data, 2);

		ret = mipi_dsi_generic_write(dsi_device, data, 2);

		break;

	case MIPI_DSI_GENERIC_READ_REQUEST_0_PARAM:

	case MIPI_DSI_GENERIC_READ_REQUEST_1_PARAM:

	case MIPI_DSI_GENERIC_READ_REQUEST_2_PARAM:

		drm_dbg_kms(display->drm, "Generic Read not yet implemented or used\n");

		ret = -EOPNOTSUPP;

		break;

	case MIPI_DSI_GENERIC_LONG_WRITE:

		mipi_dsi_generic_write(dsi_device, data, len);

		ret = mipi_dsi_generic_write(dsi_device, data, len);

		break;

	case MIPI_DSI_DCS_SHORT_WRITE:

		mipi_dsi_dcs_write_buffer(dsi_device, data, 1);

		ret = mipi_dsi_dcs_write_buffer(dsi_device, data, 1);

		break;

	case MIPI_DSI_DCS_SHORT_WRITE_PARAM:

		mipi_dsi_dcs_write_buffer(dsi_device, data, 2);

		ret = mipi_dsi_dcs_write_buffer(dsi_device, data, 2);

		break;

	case MIPI_DSI_DCS_READ:

		drm_dbg_kms(display->drm, "DCS Read not yet implemented or used\n");

		ret = -EOPNOTSUPP;

		break;

	case MIPI_DSI_DCS_LONG_WRITE:

		mipi_dsi_dcs_write_buffer(dsi_device, data, len);

		ret = mipi_dsi_dcs_write_buffer(dsi_device, data, len);

		break;

	}



	if (ret < 0)

		drm_err(display->drm, "DSI send packet failed with %pe\n", ERR_PTR(ret));



	if (DISPLAY_VER(display) < 11)

		vlv_dsi_wait_for_fifo_empty(intel_dsi, port);