Commit 241d6a66 authored by Colin Ian King's avatar Colin Ian King Committed by Paul Moore
Browse files

security: remove redundant assignment to return variable 



In the case where rc is equal to EOPNOTSUPP it is being reassigned a
new value of zero that is never read. The following continue statement
loops back to the next iteration of the lsm_for_each_hook loop and
rc is being re-assigned a new value from the call to getselfattr.
The assignment is redundant and can be removed.

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Reviewed-by: default avatarSerge Hallyn <serge@hallyn.com>
[PM: subj tweak]
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
parent 7ccbe076

security/security.c

+1 −3
Original line number Diff line number Diff line
@@ -4138,10 +4138,8 @@ int security_getselfattr(unsigned int attr, struct lsm_ctx __user *uctx, 
		if (base)

			uctx = (struct lsm_ctx __user *)(base + total);

		rc = scall->hl->hook.getselfattr(attr, uctx, &entrysize, flags);

		if (rc == -EOPNOTSUPP) {

			rc = 0;

		if (rc == -EOPNOTSUPP)

			continue;

		}

		if (rc == -E2BIG) {

			rc = 0;

			left = 0;