Commit 243efbdf authored by Zizhi Wo's avatar Zizhi Wo Committed by Theodore Ts'o
Browse files

ext4: update the comment about mb_optimize_scan 



Commit 196e402a ("ext4: improve cr 0 / cr 1 group scanning") introduces
the sysfs control interface "mb_max_linear_groups" to address the problem
that rotational devices performance degrades when the "mb_optimize_scan"
feature is enabled, which may result in distant block group allocation.

However, the name of the interface was incorrect in the comment to the
ext4/mballoc.c file, and this patch fixes it, without further changes.

Signed-off-by: default avatarZizhi Wo <wozizhi@huawei.com>
Reviewed-by: default avatarBaokun Li <libaokun1@huawei.com>
Reviewed-by: default avatarOjaswin Mujoo <ojaswin@linux.ibm.com>
Reviewed-by: default avatarZhang Yi <yi.zhang@huawei.com>
Link: https://patch.msgid.link/20250224012005.689549-1-wozizhi@huawei.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 18aba2ad

fs/ext4/mballoc.c

+2 −2
Original line number Diff line number Diff line
@@ -187,7 +187,7 @@ 
 * /sys/fs/ext4/<partition>/mb_min_to_scan

 * /sys/fs/ext4/<partition>/mb_max_to_scan

 * /sys/fs/ext4/<partition>/mb_order2_req

 * /sys/fs/ext4/<partition>/mb_linear_limit

 * /sys/fs/ext4/<partition>/mb_max_linear_groups

 *

 * The regular allocator uses buddy scan only if the request len is power of

 * 2 blocks and the order of allocation is >= sbi->s_mb_order2_reqs. The
@@ -209,7 +209,7 @@ 
 * get traversed linearly. That may result in subsequent allocations being not

 * close to each other. And so, the underlying device may get filled up in a

 * non-linear fashion. While that may not matter on non-rotational devices, for

 * rotational devices that may result in higher seek times. "mb_linear_limit"

 * rotational devices that may result in higher seek times. "mb_max_linear_groups"

 * tells mballoc how many groups mballoc should search linearly before

 * performing consulting above data structures for more efficient lookups. For

 * non rotational devices, this value defaults to 0 and for rotational devices