Commit 2442ee15 authored Apr 06, 2021 by Dave Chinner Committed by Darrick J. Wong Apr 07, 2021

xfs: eager inode attr fork init needs attr feature awareness



The pitfalls of regression testing on a machine without realising
that selinux was disabled. Only set the attr fork during inode
allocation if the attr feature bits are already set on the
superblock.

Fixes: e6a688c3 ("xfs: initialise attr fork on inode create")
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Tested-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>

parent ae7bae68

fs/xfs/xfs_inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -872,7 +872,7 @@ xfs_init_new_inode(
		* this saves us from needing to run a separate transaction to set the
		* fork offset in the immediate future.
		*/
		if (init_xattrs) {
		if (init_xattrs && xfs_sb_version_hasattr(&mp->m_sb)) {
		ip->i_forkoff = xfs_default_attroffset(ip) >> 3;
		ip->i_afp = xfs_ifork_alloc(XFS_DINODE_FMT_EXTENTS, 0);
		}