Commit 246f920c authored by Len Baker's avatar Len Baker Committed by Greg Kroah-Hartman
Browse files

staging/rtl8192u: Remove all strcpy() uses in favor of strscpy() 



strcpy() performs no bounds checking on the destination buffer. This
could result in linear overflows beyond the end of the buffer, leading
to all kinds of misbehaviors. The safe replacement is strscpy().

Signed-off-by: default avatarLen Baker <len.baker@gmx.com>
Link: https://lore.kernel.org/r/20210718113207.10045-1-len.baker@gmx.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3c667536

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

+2 −1
Original line number Diff line number Diff line
@@ -2226,7 +2226,8 @@ static void ieee80211_start_ibss_wq(struct work_struct *work) 
	mutex_lock(&ieee->wx_mutex);



	if (ieee->current_network.ssid_len == 0) {

		strcpy(ieee->current_network.ssid, IEEE80211_DEFAULT_TX_ESSID);

		strscpy(ieee->current_network.ssid, IEEE80211_DEFAULT_TX_ESSID,

			sizeof(ieee->current_network.ssid));

		ieee->current_network.ssid_len = strlen(IEEE80211_DEFAULT_TX_ESSID);

		ieee->ssid_set = 1;

	}