Commit 247d720b authored by Hajime Tazaki's avatar Hajime Tazaki Committed by Andrew Morton
Browse files

nommu: pass NULL argument to vma_iter_prealloc() 

When deleting a vma entry from a maple tree, it has to pass NULL to
vma_iter_prealloc() in order to calculate internal state of the tree, but
it passed a wrong argument.  As a result, nommu kernels crashed upon
accessing a vma iterator, such as acct_collect() reading the size of vma
entries after do_munmap().

This commit fixes this issue by passing a right argument to the
preallocation call.

Link: https://lkml.kernel.org/r/20241108222834.3625217-1-thehajime@gmail.com


Fixes: b5df0922 ("mm: set up vma iterator for vma_iter_prealloc() calls")
Signed-off-by: default avatarHajime Tazaki <thehajime@gmail.com>
Reviewed-by: default avatarLiam R. Howlett <Liam.Howlett@Oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 23aab037

mm/nommu.c

+1 −1
Original line number Diff line number Diff line
@@ -573,7 +573,7 @@ static int delete_vma_from_mm(struct vm_area_struct *vma) 
	VMA_ITERATOR(vmi, vma->vm_mm, vma->vm_start);



	vma_iter_config(&vmi, vma->vm_start, vma->vm_end);

	if (vma_iter_prealloc(&vmi, vma)) {

	if (vma_iter_prealloc(&vmi, NULL)) {

		pr_warn("Allocation of vma tree for process %d failed\n",

		       current->pid);

		return -ENOMEM;