Commit 24a19e4b authored by Wolfram Sang's avatar Wolfram Sang Committed by Hans Verkuil
Browse files

media: platform: exynos-gsc: use 'time_left' variable with wait_event_timeout() 



There is a confusing pattern in the kernel to use a variable named
'timeout' to store the result of wait_event_timeout() causing
patterns like:

        timeout = wait_event_timeout(...)
        if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the
code self explaining.

Fix to the proper variable type 'long' while here.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent bafa0065

drivers/media/platform/samsung/exynos-gsc/gsc-core.c

+5 −5
Original line number Diff line number Diff line
@@ -1225,7 +1225,7 @@ static void gsc_remove(struct platform_device *pdev) 
static int gsc_m2m_suspend(struct gsc_dev *gsc)

{

	unsigned long flags;

	int timeout;

	long time_left;



	spin_lock_irqsave(&gsc->slock, flags);

	if (!gsc_m2m_pending(gsc)) {
@@ -1236,12 +1236,12 @@ static int gsc_m2m_suspend(struct gsc_dev *gsc) 
	set_bit(ST_M2M_SUSPENDING, &gsc->state);

	spin_unlock_irqrestore(&gsc->slock, flags);



	timeout = wait_event_timeout(gsc->irq_queue,

	time_left = wait_event_timeout(gsc->irq_queue,

				       test_bit(ST_M2M_SUSPENDED, &gsc->state),

				       GSC_SHUTDOWN_TIMEOUT);



	clear_bit(ST_M2M_SUSPENDING, &gsc->state);

	return timeout == 0 ? -EAGAIN : 0;

	return time_left == 0 ? -EAGAIN : 0;

}



static void gsc_m2m_resume(struct gsc_dev *gsc)