Commit 24aaa42e authored by Nicolas Frattaroli's avatar Nicolas Frattaroli Committed by Herbert Xu
Browse files

hwrng: rockchip - eliminate some unnecessary dereferences 



Despite assigning a temporary variable the value of &pdev->dev early on
in the probe function, the probe function then continues to use this
construct when it could just use the local dev variable instead.

Simplify this by using the local dev variable directly.

Signed-off-by: default avatarNicolas Frattaroli <nicolas.frattaroli@collabora.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 8bb86092

drivers/char/hw_random/rockchip-rng.c

+3 −3
Original line number Diff line number Diff line
@@ -148,7 +148,7 @@ static int rk_rng_probe(struct platform_device *pdev) 
		return dev_err_probe(dev, rk_rng->clk_num,

				     "Failed to get clks property\n");



	rst = devm_reset_control_array_get_exclusive(&pdev->dev);

	rst = devm_reset_control_array_get_exclusive(dev);

	if (IS_ERR(rst))

		return dev_err_probe(dev, PTR_ERR(rst), "Failed to get reset property\n");
@@ -171,11 +171,11 @@ static int rk_rng_probe(struct platform_device *pdev) 
	pm_runtime_use_autosuspend(dev);

	ret = devm_pm_runtime_enable(dev);

	if (ret)

		return dev_err_probe(&pdev->dev, ret, "Runtime pm activation failed.\n");

		return dev_err_probe(dev, ret, "Runtime pm activation failed.\n");



	ret = devm_hwrng_register(dev, &rk_rng->rng);

	if (ret)

		return dev_err_probe(&pdev->dev, ret, "Failed to register Rockchip hwrng\n");

		return dev_err_probe(dev, ret, "Failed to register Rockchip hwrng\n");



	return 0;

}