Commit 24de3daf authored by Qianfeng Rong's avatar Qianfeng Rong Committed by Lizhi Hou
Browse files

accel/amdxdna: Use int instead of u32 to store error codes 



Change the 'ret' variable from u32 to int to store -EINVAL.  Storing the
negative error codes in unsigned type, doesn't cause an issue at runtime
but it's ugly as pants.

Additionally, assigning -EINVAL to u32 ret (i.e., u32 ret = -EINVAL) may
trigger a GCC warning when the -Wsign-conversion flag is enabled.

Fixes: aac24309 ("accel/amdxdna: Add command execution")
Signed-off-by: default avatarQianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: default avatarLizhi Hou <lizhi.hou@amd.com>
Signed-off-by: default avatarLizhi Hou <lizhi.hou@amd.com>
Link: https://lore.kernel.org/r/20250828033917.113364-1-rongqianfeng@vivo.com
parent 9ca595f5

drivers/accel/amdxdna/aie2_ctx.c

+3 −3
Original line number Diff line number Diff line
@@ -199,7 +199,7 @@ aie2_sched_resp_handler(void *handle, void __iomem *data, size_t size) 
{

	struct amdxdna_sched_job *job = handle;

	struct amdxdna_gem_obj *cmd_abo;

	u32 ret = 0;

	int ret = 0;

	u32 status;



	cmd_abo = job->cmd_bo;
@@ -229,7 +229,7 @@ static int 
aie2_sched_nocmd_resp_handler(void *handle, void __iomem *data, size_t size)

{

	struct amdxdna_sched_job *job = handle;

	u32 ret = 0;

	int ret = 0;

	u32 status;



	if (unlikely(!data))
@@ -257,7 +257,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size) 
	u32 fail_cmd_status;

	u32 fail_cmd_idx;

	u32 cmd_status;

	u32 ret = 0;

	int ret = 0;



	cmd_abo = job->cmd_bo;

	if (unlikely(!data) || unlikely(size != sizeof(u32) * 3)) {