Unverified Commit 251a2b11 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: ipc4-pcm: Do not run the trigger pipelines if no spipe is stored 



If the pipeline setup fails at the first widget/pipeline then we will have
no spipe stored under the pipeline_list->pipelines, the
pipeline_list->count is 0.

If this is the case we would have a NULL pointer dereference if the
execution is allowed to proceed.

Check for this condition along with the pipeline_list->pipelines check

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20230127120031.10709-19-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f94f3915

sound/soc/sof/ipc4-pcm.c

+1 −1
Original line number Diff line number Diff line
@@ -213,7 +213,7 @@ static int sof_ipc4_trigger_pipelines(struct snd_soc_component *component, 
	pipeline_list = &spcm->stream[substream->stream].pipeline_list;



	/* nothing to trigger if the list is empty */

	if (!pipeline_list->pipelines)

	if (!pipeline_list->pipelines || !pipeline_list->count)

		return 0;



	/* allocate memory for the pipeline data */