Commit 2541d182 authored by Nikolay Kulikov's avatar Nikolay Kulikov Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove custom is_multicast_mac_addr() function 



is_multicast_mac_addr() is redundant reimplementation of standard
is_multicast_ether_addr() func.
Remove it and switch to use is_multicast_ether_addr().

Signed-off-by: default avatarNikolay Kulikov <nikolayof23@gmail.com>
Link: https://patch.msgid.link/20260323150650.7168-7-nikolayof23@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1ee67763

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c

+1 −1
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ u8 rtw_validate_bssid(u8 *bssid) 


	if (is_zero_ether_addr(bssid) ||

	    is_broadcast_ether_addr(bssid) ||

	    is_multicast_mac_addr(bssid))

	    is_multicast_ether_addr(bssid))

		ret = false;



	return ret;

drivers/staging/rtl8723bs/core/rtw_recv.c

+1 −1
Original line number Diff line number Diff line
@@ -1275,7 +1275,7 @@ static signed int validate_recv_mgnt_frame(struct adapter *padapter, union recv_ 
			    ETH_ALEN))

			psta->sta_stats.rx_probersp_pkts++;

		else if (is_broadcast_ether_addr(GetAddr1Ptr(precv_frame->u.hdr.rx_data)) ||

			 is_multicast_mac_addr(GetAddr1Ptr(precv_frame->u.hdr.rx_data)))

			 is_multicast_ether_addr(GetAddr1Ptr(precv_frame->u.hdr.rx_data)))

			psta->sta_stats.rx_probersp_bm_pkts++;

		else

			psta->sta_stats.rx_probersp_uo_pkts++;

drivers/staging/rtl8723bs/include/ieee80211.h

+0 −5
Original line number Diff line number Diff line
@@ -507,11 +507,6 @@ Total: 28-2340 bytes 
#define DEFAULT_FTS 2346

#define IP_ARG(x) (x)



static inline int is_multicast_mac_addr(const u8 *addr)

{

	return ((addr[0] != 0xff) && (0x01 & addr[0]));

}



#define CFG_IEEE80211_RESERVE_FCS (1<<0)

#define CFG_IEEE80211_COMPUTE_FCS (1<<1)