Commit 2585973c authored by Haotien Hsu's avatar Haotien Hsu Committed by Greg Kroah-Hartman
Browse files

usb: gadget: tegra-xudc: Always reinitialize data toggle when clear halt 



The driver previously skipped handling ClearFeature(ENDPOINT_HALT)
when the endpoint was already not halted. This prevented the
controller from resetting the data sequence number and reinitializing
the endpoint state.

According to USB 3.2 specification Rev. 1.1, section 9.4.5,
ClearFeature(ENDPOINT_HALT) must always reset the data sequence and
set the stream state machine to Disabled, regardless of whether the
endpoint was halted.

Remove the early return so that ClearFeature(ENDPOINT_HALT) always
resets the endpoint sequence state as required by the specification.

Fixes: 49db4272 ("usb: gadget: Add UDC driver for tegra XUSB device mode controller")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarHaotien Hsu <haotienh@nvidia.com>
Signed-off-by: default avatarWayne Chang <waynec@nvidia.com>
Link: https://patch.msgid.link/20251127033540.2287517-1-waynec@nvidia.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c7bbc43a

drivers/usb/gadget/udc/tegra-xudc.c

+0 −6
Original line number Diff line number Diff line
@@ -1558,12 +1558,6 @@ static int __tegra_xudc_ep_set_halt(struct tegra_xudc_ep *ep, bool halt) 
		return -ENOTSUPP;

	}



	if (!!(xudc_readl(xudc, EP_HALT) & BIT(ep->index)) == halt) {

		dev_dbg(xudc->dev, "EP %u already %s\n", ep->index,

			halt ? "halted" : "not halted");

		return 0;

	}



	if (halt) {

		ep_halt(xudc, ep->index);

	} else {