Commit 25be3183 authored by Alexei Safin's avatar Alexei Safin Committed by Guenter Roeck
Browse files

hwmon: (asus-ec-sensors) check sensor index in read_string() 



Prevent a potential invalid memory access when the requested sensor
is not found.

find_ec_sensor_index() may return a negative value (e.g. -ENOENT),
but its result was used without checking, which could lead to
undefined behavior when passed to get_sensor_info().

Add a proper check to return -EINVAL if sensor_index is negative.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: d0ddfd24 ("hwmon: (asus-ec-sensors) add driver for ASUS EC")
Signed-off-by: default avatarAlexei Safin <a.safin@rosa.ru>
Link: https://lore.kernel.org/r/20250424202654.5902-1-a.safin@rosa.ru


[groeck: Return error code returned from find_ec_sensor_index]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a60d9659

drivers/hwmon/asus-ec-sensors.c

+4 −0
Original line number Diff line number Diff line
@@ -955,6 +955,10 @@ static int asus_ec_hwmon_read_string(struct device *dev, 
{

	struct ec_sensors_data *state = dev_get_drvdata(dev);

	int sensor_index = find_ec_sensor_index(state, type, channel);



	if (sensor_index < 0)

		return sensor_index;



	*str = get_sensor_info(state, sensor_index)->label;



	return 0;