Commit 25c12b45 authored by Kai Shen's avatar Kai Shen Committed by Jakub Kicinski
Browse files

net/smc: Fix memory leak when using percpu refs 



This patch adds missing percpu_ref_exit when releasing percpu refs.
When releasing percpu refs, percpu_ref_exit should be called.
Otherwise, memory leak happens.

Fixes: 79a22238 ("net/smc: Use percpu ref for wr tx reference")
Signed-off-by: default avatarKai Shen <KaiShen@linux.alibaba.com>
Reviewed-by: default avatarDust Li <dust.li@linux.alibaba.com>
Reviewed-by: default avatarWenjia Zhang <wenjia@linux.ibm.com>
Link: https://patch.msgid.link/20241010115624.7769-1-KaiShen@linux.alibaba.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e3e4e566

net/smc/smc_wr.c

+5 −1
Original line number Diff line number Diff line
@@ -648,8 +648,10 @@ void smc_wr_free_link(struct smc_link *lnk) 
	smc_wr_tx_wait_no_pending_sends(lnk);

	percpu_ref_kill(&lnk->wr_reg_refs);

	wait_for_completion(&lnk->reg_ref_comp);

	percpu_ref_exit(&lnk->wr_reg_refs);

	percpu_ref_kill(&lnk->wr_tx_refs);

	wait_for_completion(&lnk->tx_ref_comp);

	percpu_ref_exit(&lnk->wr_tx_refs);



	if (lnk->wr_rx_dma_addr) {

		ib_dma_unmap_single(ibdev, lnk->wr_rx_dma_addr,
@@ -912,11 +914,13 @@ int smc_wr_create_link(struct smc_link *lnk) 
	init_waitqueue_head(&lnk->wr_reg_wait);

	rc = percpu_ref_init(&lnk->wr_reg_refs, smcr_wr_reg_refs_free, 0, GFP_KERNEL);

	if (rc)

		goto dma_unmap;

		goto cancel_ref;

	init_completion(&lnk->reg_ref_comp);

	init_waitqueue_head(&lnk->wr_rx_empty_wait);

	return rc;



cancel_ref:

	percpu_ref_exit(&lnk->wr_tx_refs);

dma_unmap:

	if (lnk->wr_rx_v2_dma_addr) {

		ib_dma_unmap_single(ibdev, lnk->wr_rx_v2_dma_addr,