Commit 25ca2d57 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

serial: max3100: Convert to_max3100_port() to be static inline 



As Jiri rightfully pointed out the current to_max3100_port() macro
implementation is fragile in a sense that it expects the variable
name to be port, otherwise it blow up the build.

Change this to be static inline to prevent bad compilation.

Suggested-by: default avatarJiri Slaby <jirislaby@kernel.org>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240410141135.1378948-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 46f2bba8

drivers/tty/serial/max3100.c

+4 −1
Original line number Diff line number Diff line
@@ -111,7 +111,10 @@ struct max3100_port { 
	struct timer_list	timer;

};



#define to_max3100_port(port)	container_of(port, struct max3100_port, port)

static inline struct max3100_port *to_max3100_port(struct uart_port *port)

{

	return container_of(port, struct max3100_port, port);

}



static struct max3100_port *max3100s[MAX_MAX3100]; /* the chips */

static DEFINE_MUTEX(max3100s_lock);		   /* race on probe */