Commit 26008247 authored by Allan Stephens's avatar Allan Stephens Committed by David S. Miller
Browse files

[TIPC]: Links now validate destination node specified by incoming messages. 



This fix prevents link flopping and name table inconsistency problems arising
when a node is assigned a different <Z.C.N> value than it used previously.
(Changing the <Z.C.N> value causes other nodes to have two link endpoints
sending to the same MAC address using two different destination <Z.C.N> values,
requiring the receiving node to filter out the unwanted messages.)

Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
Signed-off-by: default avatarPer Liden <per.liden@ericsson.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9688243b

net/tipc/link.c

+5 −0
Original line number Diff line number Diff line
@@ -1720,6 +1720,11 @@ void tipc_recv_msg(struct sk_buff *head, struct tipc_bearer *tb_ptr) 
			link_recv_non_seq(buf);

			continue;

		}

		

		if (unlikely(!msg_short(msg) &&

			     (msg_destnode(msg) != tipc_own_addr)))

			goto cont;

		

		n_ptr = tipc_node_find(msg_prevnode(msg));

		if (unlikely(!n_ptr))

			goto cont;