Commit 2623c96f authored by Eric Farman's avatar Eric Farman Committed by Janosch Frank
Browse files

KVM: s390: only deliver service interrupt with payload 



Routine __inject_service() may set both the SERVICE and SERVICE_EV
pending bits, and in the case of a pure service event the corresponding
trip through __deliver_service_ev() will clear the SERVICE_EV bit only.
This necessitates an additional trip through __deliver_service() for
the other pending interrupt bit, however it is possible that the
external interrupt parameters are zero and there is nothing to be
delivered to the guest.

To avoid sending empty data to the guest, let's only write out the SCLP
data when there is something for the guest to do, otherwise bail out.

Signed-off-by: default avatarEric Farman <farman@linux.ibm.com>
Acked-by: default avatarChristian Borntraeger <borntraeger@linux.ibm.com>
Signed-off-by: default avatarChristian Borntraeger <borntraeger@linux.ibm.com>
Signed-off-by: default avatarJanosch Frank <frankja@linux.ibm.com>
parent 11439c46

arch/s390/kvm/interrupt.c

+3 −0
Original line number Diff line number Diff line
@@ -956,6 +956,9 @@ static int __must_check __deliver_service(struct kvm_vcpu *vcpu) 
		set_bit(IRQ_PEND_EXT_SERVICE, &fi->masked_irqs);

	spin_unlock(&fi->lock);



	if (!ext.ext_params)

		return 0;



	VCPU_EVENT(vcpu, 4, "deliver: sclp parameter 0x%x",

		   ext.ext_params);

	vcpu->stat.deliver_service_signal++;