Commit 26265dd6 authored by Cássio Gabriel's avatar Cássio Gabriel Committed by Takashi Iwai
Browse files

ALSA: usb-audio: Fix UAC3 cluster descriptor size check 



The UAC3 cluster descriptor length check in
snd_usb_get_audioformat_uac3()was added to
make sure that the buffer is large enough for
a struct uac3_cluster_header_descriptor before the
returned data is cast and used.

However, the check uses sizeof(cluster), where cluster
is a pointer, not the size of the descriptor header.
This makes the validation depend on the architecture
pointer size and does not match the intended object size.

Check against sizeof(*cluster) instead.

Fixes: fb4e2a6e ("ALSA: usb-audio: Fix out-of-bounds read in snd_usb_get_audioformat_uac3()")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarCássio Gabriel <cassiogabrielcontato@gmail.com>
Link: https://patch.msgid.link/20260424-alsa-usb-uac3-cluster-size-v1-1-99a5808898a3@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e5c33cdc

sound/usb/stream.c

+1 −1
Original line number Diff line number Diff line
@@ -1003,7 +1003,7 @@ snd_usb_get_audioformat_uac3(struct snd_usb_audio *chip, 
	 * and request Cluster Descriptor

	 */

	wLength = le16_to_cpu(hc_header.wLength);

	if (wLength < sizeof(cluster))

	if (wLength < sizeof(*cluster))

		return NULL;

	cluster = kzalloc(wLength, GFP_KERNEL);

	if (!cluster)