Unverified Commit 263cf578 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Christian Brauner
Browse files

befs: Convert befs_symlink_read_folio() to use folio_end_read() 



This is slightly more efficient than separate calls to
folio_mark_uptodate() and folio_unlock(), and it's easier to read.
Get rid of the call to folio_set_error() as nobody will check this flag.

Cc: Luis de Bethencourt <luisbg@kernel.org>
Cc: Salah Triki <salah.triki@gmail.com>
Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Link: https://lore.kernel.org/r/20240530202110.2653630-2-willy@infradead.org


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 1613e604

fs/befs/linuxvfs.c

+4 −6
Original line number Diff line number Diff line
@@ -475,6 +475,7 @@ static int befs_symlink_read_folio(struct file *unused, struct folio *folio) 
	befs_data_stream *data = &befs_ino->i_data.ds;

	befs_off_t len = data->size;

	char *link = folio_address(folio);

	int err = -EIO;



	if (len == 0 || len > PAGE_SIZE) {

		befs_error(sb, "Long symlink with illegal length");
@@ -487,13 +488,10 @@ static int befs_symlink_read_folio(struct file *unused, struct folio *folio) 
		goto fail;

	}

	link[len - 1] = '\0';

	folio_mark_uptodate(folio);

	folio_unlock(folio);

	return 0;

	err = 0;

fail:

	folio_set_error(folio);

	folio_unlock(folio);

	return -EIO;

	folio_end_read(folio, err == 0);

	return err;

}



/*