Commit 26b63bee authored by Wentao Liang's avatar Wentao Liang Committed by Carlos Maiolino
Browse files

xfs: Add error handling for xfs_reflink_cancel_cow_range 



In xfs_inactive(), xfs_reflink_cancel_cow_range() is called
without error handling, risking unnoticed failures and
inconsistent behavior compared to other parts of the code.

Fix this issue by adding an error handling for the
xfs_reflink_cancel_cow_range(), improving code robustness.

Fixes: 6231848c ("xfs: check for cow blocks before trying to clear them")
Cc: stable@vger.kernel.org # v4.17
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarWentao Liang <vulab@iscas.ac.cn>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent fb95897b

fs/xfs/xfs_inode.c

+5 −2
Original line number Diff line number Diff line
@@ -1404,8 +1404,11 @@ xfs_inactive( 
		goto out;



	/* Try to clean out the cow blocks if there are any. */

	if (xfs_inode_has_cow_data(ip))

		xfs_reflink_cancel_cow_range(ip, 0, NULLFILEOFF, true);

	if (xfs_inode_has_cow_data(ip)) {

		error = xfs_reflink_cancel_cow_range(ip, 0, NULLFILEOFF, true);

		if (error)

			goto out;

	}



	if (VFS_I(ip)->i_nlink != 0) {

		/*