Commit 26b971d5 authored by mrigendrachaubey's avatar mrigendrachaubey Committed by Martin K. Petersen
Browse files

scsi: scsi_devinfo: Remove redundant 'found' 



Remove the unnecessary 'found' flag in scsi_devinfo_lookup_by_key(). The
loop can return the matching entry directly when found, and fall through
to return ERR_PTR(-EINVAL) otherwise.

Signed-off-by: default avatarmrigendrachaubey <mrigendra.chaubey@gmail.com>
Link: https://lore.kernel.org/r/20250622055709.7893-1-mrigendra.chaubey@gmail.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 6243146b

drivers/scsi/scsi_devinfo.c

+3 −8
Original line number Diff line number Diff line
@@ -269,17 +269,12 @@ static struct { 
static struct scsi_dev_info_list_table *scsi_devinfo_lookup_by_key(int key)

{

	struct scsi_dev_info_list_table *devinfo_table;

	int found = 0;



	list_for_each_entry(devinfo_table, &scsi_dev_info_list, node)

		if (devinfo_table->key == key) {

			found = 1;

			break;

		}

	if (!found)

		return ERR_PTR(-EINVAL);



		if (devinfo_table->key == key)

			return devinfo_table;



	return ERR_PTR(-EINVAL);

}



/*