Commit 26e0fd1c authored by Patrick McHardy's avatar Patrick McHardy Committed by David S. Miller
Browse files

[NET]: Fix IPv4/DECnet routing rule dumping 



When more rules are present than fit in a single skb, the remaining
rules are incorrectly skipped.

Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a430a43d

net/decnet/dn_rules.c

+2 −1
Original line number Diff line number Diff line
@@ -399,9 +399,10 @@ int dn_fib_dump_rules(struct sk_buff *skb, struct netlink_callback *cb) 
	rcu_read_lock();

	hlist_for_each_entry(r, node, &dn_fib_rules, r_hlist) {

		if (idx < s_idx)

			continue;

			goto next;

		if (dn_fib_fill_rule(skb, r, cb, NLM_F_MULTI) < 0)

			break;

next:

		idx++;

	}

	rcu_read_unlock();

net/ipv4/fib_rules.c

+2 −2
Original line number Diff line number Diff line
@@ -457,13 +457,13 @@ int inet_dump_rules(struct sk_buff *skb, struct netlink_callback *cb) 


	rcu_read_lock();

	hlist_for_each_entry(r, node, &fib_rules, hlist) {



		if (idx < s_idx)

			continue;

			goto next;

		if (inet_fill_rule(skb, r, NETLINK_CB(cb->skb).pid,

				   cb->nlh->nlmsg_seq,

				   RTM_NEWRULE, NLM_F_MULTI) < 0)

			break;

next:

		idx++;

	}

	rcu_read_unlock();