Commit 272f99ed authored by Johan Hovold's avatar Johan Hovold Committed by Lee Jones
Browse files

spmi: rename spmi device lookup helper 



Rename the SPMI device helper which is used to lookup a device from its
OF node as spmi_find_device_by_of_node() so that it reflects the
implementation and matches how other helpers like this are named.

This will specifically make it more clear that this is a lookup function
which returns a reference counted structure.

Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Acked-by: default avatarStephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20231003152927.15000-6-johan+linaro@kernel.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent ade7941a

drivers/mfd/qcom-spmi-pmic.c

+1 −1
Original line number Diff line number Diff line
@@ -116,7 +116,7 @@ static struct spmi_device *qcom_pmic_get_base_usid(struct spmi_device *sdev, str 
		}



		if (pmic_addr == function_parent_usid - (ctx->num_usids - 1)) {

			sdev = spmi_device_from_of(child);

			sdev = spmi_find_device_by_of_node(child);

			if (!sdev) {

				/*

				 * If the base USID for this PMIC hasn't been

drivers/spmi/spmi.c

+3 −3
Original line number Diff line number Diff line
@@ -388,7 +388,7 @@ static struct bus_type spmi_bus_type = { 
};



/**

 * spmi_device_from_of() - get the associated SPMI device from a device node

 * spmi_find_device_by_of_node() - look up an SPMI device from a device node

 *

 * @np:		device node

 *
@@ -397,7 +397,7 @@ static struct bus_type spmi_bus_type = { 
 *

 * Returns the struct spmi_device associated with a device node or NULL.

 */

struct spmi_device *spmi_device_from_of(struct device_node *np)

struct spmi_device *spmi_find_device_by_of_node(struct device_node *np)

{

	struct device *dev = bus_find_device_by_of_node(&spmi_bus_type, np);
@@ -405,7 +405,7 @@ struct spmi_device *spmi_device_from_of(struct device_node *np) 
		return to_spmi_device(dev);

	return NULL;

}

EXPORT_SYMBOL_GPL(spmi_device_from_of);

EXPORT_SYMBOL_GPL(spmi_find_device_by_of_node);



/**

 * spmi_device_alloc() - Allocate a new SPMI device

include/linux/spmi.h

+1 −1
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ static inline void spmi_driver_unregister(struct spmi_driver *sdrv) 


struct device_node;



struct spmi_device *spmi_device_from_of(struct device_node *np);

struct spmi_device *spmi_find_device_by_of_node(struct device_node *np);

int spmi_register_read(struct spmi_device *sdev, u8 addr, u8 *buf);

int spmi_ext_register_read(struct spmi_device *sdev, u8 addr, u8 *buf,

			   size_t len);