Commit 279c2402 authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Alexandre Belloni
Browse files

i3c: mipi-i3c-hci: Fix handling status of i3c_hci_irq_handler() 



Return IRQ_HANDLED from the i3c_hci_irq_handler() only if some
INTR_STATUS bit was set or if DMA/PIO handler handled it.

Currently it returns IRQ_HANDLED in case INTR_STATUS is zero and IO
handler returns false. Which could be the case if interrupt comes from
other device or is spurious.

Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Signed-off-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/20250409140401.299251-2-jarkko.nikula@linux.intel.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent eeeec6c5

drivers/i3c/master/mipi-i3c-hci/core.c

+3 −3
Original line number Diff line number Diff line
@@ -594,6 +594,7 @@ static irqreturn_t i3c_hci_irq_handler(int irq, void *dev_id) 


	if (val) {

		reg_write(INTR_STATUS, val);

		result = IRQ_HANDLED;

	}



	if (val & INTR_HC_RESET_CANCEL) {
@@ -605,12 +606,11 @@ static irqreturn_t i3c_hci_irq_handler(int irq, void *dev_id) 
		val &= ~INTR_HC_INTERNAL_ERR;

	}



	hci->io->irq_handler(hci);

	if (hci->io->irq_handler(hci))

		result = IRQ_HANDLED;



	if (val)

		dev_err(&hci->master.dev, "unexpected INTR_STATUS %#x\n", val);

	else

		result = IRQ_HANDLED;



	return result;

}