Commit 27a40462 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Vinod Koul
Browse files

phy: ti: gmii-sel: Simplify with dev_err_probe() 



Use dev_err_probe() to avoid dmesg flood on actual defer.  This makes
the code also simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240826-phy-of-node-scope-v1-9-5b4d82582644@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 29b44a38

drivers/phy/ti/phy-gmii-sel.c

+6 −10
Original line number Diff line number Diff line
@@ -468,11 +468,9 @@ static int phy_gmii_sel_probe(struct platform_device *pdev) 
	priv->regmap = syscon_node_to_regmap(node->parent);

	if (IS_ERR(priv->regmap)) {

		priv->regmap = device_node_to_regmap(node);

		if (IS_ERR(priv->regmap)) {

			ret = PTR_ERR(priv->regmap);

			dev_err(dev, "Failed to get syscon %d\n", ret);

			return ret;

		}

		if (IS_ERR(priv->regmap))

			return dev_err_probe(dev, PTR_ERR(priv->regmap),

					     "Failed to get syscon\n");

		priv->no_offset = true;

	}
@@ -485,11 +483,9 @@ static int phy_gmii_sel_probe(struct platform_device *pdev) 
	priv->phy_provider =

		devm_of_phy_provider_register(dev,

					      phy_gmii_sel_of_xlate);

	if (IS_ERR(priv->phy_provider)) {

		ret = PTR_ERR(priv->phy_provider);

		dev_err(dev, "Failed to create phy provider %d\n", ret);

		return ret;

	}

	if (IS_ERR(priv->phy_provider))

		return dev_err_probe(dev, PTR_ERR(priv->phy_provider),

				     "Failed to create phy provider\n");



	return 0;

}