Commit 27af31e4 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Thomas Gleixner
Browse files

hrtimers: Mark is_migration_base() with __always_inline 



When is_migration_base() is unused, it prevents kernel builds
with clang, `make W=1` and CONFIG_WERROR=y:

kernel/time/hrtimer.c:156:20: error: unused function 'is_migration_base' [-Werror,-Wunused-function]
  156 | static inline bool is_migration_base(struct hrtimer_clock_base *base)
      |                    ^~~~~~~~~~~~~~~~~

Fix this by marking it with __always_inline.

[ tglx: Use __always_inline instead of __maybe_unused and move it into the
  	usage sites conditional ]

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250116160745.243358-1-andriy.shevchenko@linux.intel.com
parent c4b9570c

kernel/time/hrtimer.c

+12 −10
Original line number Diff line number Diff line
@@ -145,11 +145,6 @@ static struct hrtimer_cpu_base migration_cpu_base = { 


#define migration_base	migration_cpu_base.clock_base[0]



static inline bool is_migration_base(struct hrtimer_clock_base *base)

{

	return base == &migration_base;

}



/*

 * We are using hashed locking: holding per_cpu(hrtimer_bases)[n].lock

 * means that all timers which are tied to this base via timer->base are
@@ -275,11 +270,6 @@ switch_hrtimer_base(struct hrtimer *timer, struct hrtimer_clock_base *base, 


#else /* CONFIG_SMP */



static inline bool is_migration_base(struct hrtimer_clock_base *base)

{

	return false;

}



static inline struct hrtimer_clock_base *

lock_hrtimer_base(const struct hrtimer *timer, unsigned long *flags)

	__acquires(&timer->base->cpu_base->lock)
@@ -1370,6 +1360,18 @@ static void hrtimer_sync_wait_running(struct hrtimer_cpu_base *cpu_base, 
	}

}



#ifdef CONFIG_SMP

static __always_inline bool is_migration_base(struct hrtimer_clock_base *base)

{

	return base == &migration_base;

}

#else

static __always_inline bool is_migration_base(struct hrtimer_clock_base *base)

{

	return false;

}

#endif



/*

 * This function is called on PREEMPT_RT kernels when the fast path

 * deletion of a timer failed because the timer callback function was