Commit 27ba9256 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Paolo Abeni
Browse files

selftests: drv-net: xdp: add test for interface level qstats 



Send a non-trivial number of packets and make sure that they
are counted correctly in qstats. Per qstats specification
XDP is the first layer of the stack so we should see Rx and Tx
counters go up for packets which went thru XDP.

Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20251007232653.2099376-6-kuba@kernel.org


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 1ad3f620

tools/testing/selftests/drivers/net/xdp.py

+89 −2
Original line number Diff line number Diff line
@@ -11,8 +11,9 @@ import string 
from dataclasses import dataclass

from enum import Enum



from lib.py import ksft_run, ksft_exit, ksft_eq, ksft_ne, ksft_pr

from lib.py import KsftFailEx, NetDrvEpEnv, EthtoolFamily, NlError

from lib.py import ksft_run, ksft_exit, ksft_eq, ksft_ge, ksft_ne, ksft_pr

from lib.py import KsftFailEx, NetDrvEpEnv

from lib.py import EthtoolFamily, NetdevFamily, NlError

from lib.py import bkg, cmd, rand_port, wait_port_listen

from lib.py import ip, bpftool, defer
@@ -671,6 +672,88 @@ def test_xdp_native_adjst_head_shrnk_data(cfg): 
    _validate_res(res, offset_lst, pkt_sz_lst)





def _test_xdp_native_ifc_stats(cfg, act):

    cfg.require_cmd("socat")



    bpf_info = BPFProgInfo("xdp_prog", "xdp_native.bpf.o", "xdp", 1500)

    prog_info = _load_xdp_prog(cfg, bpf_info)

    port = rand_port()



    _set_xdp_map("map_xdp_setup", TestConfig.MODE.value, act.value)

    _set_xdp_map("map_xdp_setup", TestConfig.PORT.value, port)



    # Discard the input, but we need a listener to avoid ICMP errors

    rx_udp = f"socat -{cfg.addr_ipver} -T 2 -u UDP-RECV:{port},reuseport " + \

        "/dev/null"

    # Listener runs on "remote" in case of XDP_TX

    rx_host = cfg.remote if act == XDPAction.TX else None

    # We want to spew 2000 packets quickly, bash seems to do a good enough job

    tx_udp =  f"exec 5<>/dev/udp/{cfg.addr}/{port}; " \

        "for i in `seq 2000`; do echo a >&5; done; exec 5>&-"



    cfg.wait_hw_stats_settle()

    # Qstats have more clearly defined semantics than rtnetlink.

    # XDP is the "first layer of the stack" so XDP packets should be counted

    # as received and sent as if the decision was made in the routing layer.

    before = cfg.netnl.qstats_get({"ifindex": cfg.ifindex}, dump=True)[0]



    with bkg(rx_udp, host=rx_host, exit_wait=True):

        wait_port_listen(port, proto="udp", host=rx_host)

        cmd(tx_udp, host=cfg.remote, shell=True)



    cfg.wait_hw_stats_settle()

    after = cfg.netnl.qstats_get({"ifindex": cfg.ifindex}, dump=True)[0]



    ksft_ge(after['rx-packets'] - before['rx-packets'], 2000)

    if act == XDPAction.TX:

        ksft_ge(after['tx-packets'] - before['tx-packets'], 2000)



    expected_pkts = 2000

    stats = _get_stats(prog_info["maps"]["map_xdp_stats"])

    ksft_eq(stats[XDPStats.RX.value], expected_pkts, "XDP RX stats mismatch")

    if act == XDPAction.TX:

        ksft_eq(stats[XDPStats.TX.value], expected_pkts, "XDP TX stats mismatch")



    # Flip the ring count back and forth to make sure the stats from XDP rings

    # don't get lost.

    chans = cfg.ethnl.channels_get({'header': {'dev-index': cfg.ifindex}})

    if chans.get('combined-count', 0) > 1:

        cfg.ethnl.channels_set({'header': {'dev-index': cfg.ifindex},

                                'combined-count': 1})

        cfg.ethnl.channels_set({'header': {'dev-index': cfg.ifindex},

                                'combined-count': chans['combined-count']})

        before = after

        after = cfg.netnl.qstats_get({"ifindex": cfg.ifindex}, dump=True)[0]



        ksft_ge(after['rx-packets'], before['rx-packets'])

        if act == XDPAction.TX:

            ksft_ge(after['tx-packets'], before['tx-packets'])





def test_xdp_native_qstats_pass(cfg):

    """

    Send 2000 messages, expect XDP_PASS, make sure the packets were counted

    to interface level qstats (Rx).

    """

    _test_xdp_native_ifc_stats(cfg, XDPAction.PASS)





def test_xdp_native_qstats_drop(cfg):

    """

    Send 2000 messages, expect XDP_DROP, make sure the packets were counted

    to interface level qstats (Rx).

    """

    _test_xdp_native_ifc_stats(cfg, XDPAction.DROP)





def test_xdp_native_qstats_tx(cfg):

    """

    Send 2000 messages, expect XDP_TX, make sure the packets were counted

    to interface level qstats (Rx and Tx)

    """

    _test_xdp_native_ifc_stats(cfg, XDPAction.TX)





def main():

    """

    Main function to execute the XDP tests.
@@ -682,6 +765,7 @@ def main(): 
    """

    with NetDrvEpEnv(__file__) as cfg:

        cfg.ethnl = EthtoolFamily()

        cfg.netnl = NetdevFamily()

        ksft_run(

            [

                test_xdp_native_pass_sb,
@@ -694,6 +778,9 @@ def main(): 
                test_xdp_native_adjst_tail_shrnk_data,

                test_xdp_native_adjst_head_grow_data,

                test_xdp_native_adjst_head_shrnk_data,

                test_xdp_native_qstats_pass,

                test_xdp_native_qstats_drop,

                test_xdp_native_qstats_tx,

            ],

            args=(cfg,))

    ksft_exit()