Commit 27e58f76 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915/wm: Extract skl_print_plane_ddb_changes() 



We have skl_print_plane_wm_changes() but the DDB counterpart is
just inline in the main loop. Extract it into a function. We'll
have a second use for this soon.

The "ddb" part is already parametrized in anticipation of the
second user.

v2: Use prink field width for ddb_name alignment

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260319114034.7093-8-ville.syrjala@linux.intel.com


Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
parent e2a5a5b8

drivers/gpu/drm/i915/display/skl_watermark.c

+17 −5
Original line number Diff line number Diff line
@@ -2601,6 +2601,21 @@ static char enast(bool enable) 
	return enable ? '*' : ' ';

}



static void

skl_print_plane_ddb_changes(struct intel_plane *plane,

			    const struct skl_ddb_entry *old,

			    const struct skl_ddb_entry *new,

			    const char *ddb_name)

{

	struct intel_display *display = to_intel_display(plane);



	drm_dbg_kms(display->drm,

		    "[PLANE:%d:%s] %5s (%4d - %4d) -> (%4d - %4d), size %4d -> %4d\n",

		    plane->base.base.id, plane->base.name, ddb_name,

		    old->start, old->end, new->start, new->end,

		    skl_ddb_entry_size(old), skl_ddb_entry_size(new));

}



static noinline_for_stack void

skl_print_plane_wm_changes(struct intel_plane *plane,

			   const struct skl_plane_wm *old_wm,
@@ -2722,11 +2737,8 @@ skl_print_wm_changes(struct intel_atomic_state *state) 


			if (skl_ddb_entry_equal(old, new))

				continue;

			drm_dbg_kms(display->drm,

				    "[PLANE:%d:%s] ddb (%4d - %4d) -> (%4d - %4d), size %4d -> %4d\n",

				    plane->base.base.id, plane->base.name,

				    old->start, old->end, new->start, new->end,

				    skl_ddb_entry_size(old), skl_ddb_entry_size(new));



			skl_print_plane_ddb_changes(plane, old, new, "ddb");

		}



		for_each_intel_plane_on_crtc(display->drm, crtc, plane) {