Unverified Commit 27fef304 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mark Brown
Browse files

regcache: flat: Remove unneeded check and error message for -ENOMEM 



There is a convention in the kernel to avoid error messages
in the cases of -ENOMEM errors. Besides that, the idea behind
using struct_size() and other macros from overflow.h is
to saturate the size that the following allocation call will
definitely fail, hence the check and the error messaging added
in regcache_flat_init() are redundant. Remove them.

Acked-by: default avatarSander Vanheule <sander@svanheule.net>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20251031080540.3970776-4-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bda6f874

drivers/base/regmap/regcache-flat.c

+1 −9
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ struct regcache_flat_data { 
static int regcache_flat_init(struct regmap *map)

{

	int i;

	size_t cache_data_size;

	unsigned int cache_size;

	struct regcache_flat_data *cache;
@@ -38,14 +37,7 @@ static int regcache_flat_init(struct regmap *map) 
		return -EINVAL;



	cache_size = regcache_flat_get_index(map, map->max_register) + 1;

	cache_data_size = struct_size(cache, data, cache_size);



	if (cache_data_size == SIZE_MAX) {

		dev_err(map->dev, "cannot allocate regmap cache");

		return -ENOMEM;

	}



	cache = kzalloc(cache_data_size, map->alloc_flags);

	cache = kzalloc(struct_size(cache, data, cache_size), map->alloc_flags);

	if (!cache)

		return -ENOMEM;