Commit 280939bd authored by Johan Hovold's avatar Johan Hovold Committed by Luiz Augusto von Dentz
Browse files

Bluetooth: qca: drop bogus edl header checks 



The skb->data pointer is never NULL so drop the bogus sanity checks when
initialising the EDL header pointer.

Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent b33a0d29

drivers/bluetooth/btqca.c

+0 −20
Original line number Diff line number Diff line
@@ -55,11 +55,6 @@ int qca_read_soc_version(struct hci_dev *hdev, struct qca_btsoc_version *ver, 
	}



	edl = (struct edl_event_hdr *)(skb->data);

	if (!edl) {

		bt_dev_err(hdev, "QCA TLV with no header");

		err = -EILSEQ;

		goto out;

	}



	if (edl->cresp != EDL_CMD_REQ_RES_EVT ||

	    edl->rtype != rtype) {
@@ -121,11 +116,6 @@ static int qca_read_fw_build_info(struct hci_dev *hdev) 
	}



	edl = (struct edl_event_hdr *)(skb->data);

	if (!edl) {

		bt_dev_err(hdev, "QCA read fw build info with no header");

		err = -EILSEQ;

		goto out;

	}



	if (edl->cresp != EDL_CMD_REQ_RES_EVT ||

	    edl->rtype != EDL_GET_BUILD_INFO_CMD) {
@@ -183,11 +173,6 @@ static int qca_send_patch_config_cmd(struct hci_dev *hdev) 
	}



	edl = (struct edl_event_hdr *)(skb->data);

	if (!edl) {

		bt_dev_err(hdev, "QCA Patch config with no header");

		err = -EILSEQ;

		goto out;

	}



	if (edl->cresp != EDL_PATCH_CONFIG_RES_EVT || edl->rtype != EDL_PATCH_CONFIG_CMD) {

		bt_dev_err(hdev, "QCA Wrong packet received %d %d", edl->cresp,
@@ -502,11 +487,6 @@ static int qca_tlv_send_segment(struct hci_dev *hdev, int seg_size, 
	}



	edl = (struct edl_event_hdr *)(skb->data);

	if (!edl) {

		bt_dev_err(hdev, "TLV with no header");

		err = -EILSEQ;

		goto out;

	}



	if (edl->cresp != EDL_CMD_REQ_RES_EVT || edl->rtype != rtype) {

		bt_dev_err(hdev, "QCA TLV with error stat 0x%x rtype 0x%x",