Commit 2828c318 authored by Thorsten Blum's avatar Thorsten Blum Committed by Greg Kroah-Hartman
Browse files

misc: ad525x_dpot: Use str_enabled_disabled() in sysfs_show_reg() 



Remove hard-coded strings by using the str_enabled_disabled() helper
function and silence the following Coccinelle/coccicheck warning
reported by string_choices.cocci:

  opportunity for str_enabled_disabled(..)

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://lore.kernel.org/r/20250820102734.760844-2-thorsten.blum@linux.dev


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d8959245

drivers/misc/ad525x_dpot.c

+3 −4
Original line number Diff line number Diff line
@@ -73,6 +73,7 @@ 
#include <linux/kernel.h>

#include <linux/delay.h>

#include <linux/slab.h>

#include <linux/string_choices.h>



#include "ad525x_dpot.h"
@@ -418,10 +419,8 @@ static ssize_t sysfs_show_reg(struct device *dev, 
	s32 value;



	if (reg & DPOT_ADDR_OTP_EN)

		return sprintf(buf, "%s\n",

			test_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask) ?

			"enabled" : "disabled");



		return sprintf(buf, "%s\n", str_enabled_disabled(

			test_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask)));



	mutex_lock(&data->update_lock);

	value = dpot_read(data, reg);