Commit 283cf357 authored by Yang Yingliang's avatar Yang Yingliang Committed by Ulf Hansson
Browse files

mmc: remove unnecessary set_drvdata() function 



The driver data will be cleared in device_unbind_cleanup() in driver
core code. So the set_drvdata(..., NULL) called in remove and error
path in probe can be removed.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20230808121513.553143-1-yangyingliang@huawei.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 117d73b1

drivers/mmc/core/block.c

+0 −1
Original line number Diff line number Diff line
@@ -3026,7 +3026,6 @@ static void mmc_blk_remove(struct mmc_card *card) 
		pm_runtime_disable(&card->dev);

	pm_runtime_put_noidle(&card->dev);

	mmc_blk_remove_req(md);

	dev_set_drvdata(&card->dev, NULL);

	destroy_workqueue(card->complete_wq);

}

drivers/mmc/host/moxart-mmc.c

+0 −2
Original line number Diff line number Diff line
@@ -692,8 +692,6 @@ static int moxart_remove(struct platform_device *pdev) 
	struct mmc_host *mmc = dev_get_drvdata(&pdev->dev);

	struct moxart_host *host = mmc_priv(mmc);



	dev_set_drvdata(&pdev->dev, NULL);



	if (!IS_ERR_OR_NULL(host->dma_chan_tx))

		dma_release_channel(host->dma_chan_tx);

	if (!IS_ERR_OR_NULL(host->dma_chan_rx))

drivers/mmc/host/sunplus-mmc.c

+0 −1
Original line number Diff line number Diff line
@@ -948,7 +948,6 @@ static int spmmc_drv_remove(struct platform_device *dev) 
	clk_disable_unprepare(host->clk);

	pm_runtime_put_noidle(&dev->dev);

	pm_runtime_disable(&dev->dev);

	platform_set_drvdata(dev, NULL);



	return 0;

}

drivers/mmc/host/via-sdmmc.c

+0 −2
Original line number Diff line number Diff line
@@ -1160,7 +1160,6 @@ static int via_sd_probe(struct pci_dev *pcidev, 
unmap:

	iounmap(sdhost->mmiobase);

free_mmc_host:

	dev_set_drvdata(&pcidev->dev, NULL);

	mmc_free_host(mmc);

release:

	pci_release_regions(pcidev);
@@ -1212,7 +1211,6 @@ static void via_sd_remove(struct pci_dev *pcidev) 
	writeb(gatt, sdhost->pcictrl_mmiobase + VIA_CRDR_PCICLKGATT);



	iounmap(sdhost->mmiobase);

	dev_set_drvdata(&pcidev->dev, NULL);

	mmc_free_host(sdhost->mmc);

	pci_release_regions(pcidev);

	pci_disable_device(pcidev);

drivers/mmc/host/wbsd.c

+0 −2
Original line number Diff line number Diff line
@@ -1264,8 +1264,6 @@ static void wbsd_free_mmc(struct device *dev) 
	del_timer_sync(&host->ignore_timer);



	mmc_free_host(mmc);



	dev_set_drvdata(dev, NULL);

}



/*