Commit 284e9d1e authored by Jacob Keller's avatar Jacob Keller Committed by Jakub Kicinski
Browse files

devlink: remove unnecessary parameter from chunk_fill function 



The devlink parameter of the devlink_nl_cmd_region_read_chunk_fill
function is not used. Remove it, to simplify the function signature.

Once removed, it is also obvious that the devlink parameter is not
necessary for the devlink_nl_region_read_snapshot_fill either.

Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e004ea10

net/core/devlink.c

+2 −8
Original line number Diff line number Diff line
@@ -6431,7 +6431,6 @@ devlink_nl_cmd_region_new(struct sk_buff *skb, struct genl_info *info) 
}



static int devlink_nl_cmd_region_read_chunk_fill(struct sk_buff *msg,

						 struct devlink *devlink,

						 u8 *chunk, u32 chunk_size,

						 u64 addr)

{
@@ -6462,7 +6461,6 @@ static int devlink_nl_cmd_region_read_chunk_fill(struct sk_buff *msg, 
#define DEVLINK_REGION_READ_CHUNK_SIZE 256



static int devlink_nl_region_read_snapshot_fill(struct sk_buff *skb,

						struct devlink *devlink,

						struct devlink_snapshot *snapshot,

						u64 start_offset,

						u64 end_offset,
@@ -6481,9 +6479,7 @@ static int devlink_nl_region_read_snapshot_fill(struct sk_buff *skb, 
				  DEVLINK_REGION_READ_CHUNK_SIZE);



		data = &snapshot->data[curr_offset];

		err = devlink_nl_cmd_region_read_chunk_fill(skb, devlink,

							    data, data_size,

							    curr_offset);

		err = devlink_nl_cmd_region_read_chunk_fill(skb, data, data_size, curr_offset);

		if (err)

			break;
@@ -6612,9 +6608,7 @@ static int devlink_nl_cmd_region_read_dumpit(struct sk_buff *skb, 
		goto nla_put_failure;

	}



	err = devlink_nl_region_read_snapshot_fill(skb, devlink,

						   snapshot,

						   start_offset,

	err = devlink_nl_region_read_snapshot_fill(skb, snapshot, start_offset,

						   end_offset, &ret_offset);



	if (err && err != -EMSGSIZE)